-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gh-pages] remove build-index.sh #698
Open
ArangoGutierrez
wants to merge
2
commits into
NVIDIA:gh-pages
Choose a base branch
from
ArangoGutierrez:nowWithActions
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depends on #691 |
elezar
reviewed
May 7, 2024
Now that #691 is in, we can revisit this one |
elezar
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update the instructions following the merged changes.
ArangoGutierrez
force-pushed
the
nowWithActions
branch
from
June 26, 2024 09:22
2c62079
to
093a759
Compare
PING @elezar , ready for a next round of reviews |
elezar
requested changes
Jul 16, 2024
ArangoGutierrez
force-pushed
the
nowWithActions
branch
from
July 16, 2024 14:34
af8b8d6
to
89e32a4
Compare
REFRESH |
Rebased |
elezar
previously requested changes
Aug 9, 2024
This patch removes the build-index.sh script Also adds documentation on how to use the new script at `main` to update the Helm charts and index. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
ArangoGutierrez
force-pushed
the
nowWithActions
branch
from
August 9, 2024 10:08
61360ed
to
21faf4a
Compare
Ready for review, all requested changes have been addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the build-index.sh script
Also adds documentation on how to use the new script at
main
to update the Helm charts and index.